-
Notifications
You must be signed in to change notification settings - Fork 76
Make contributions easier by making PR requests testable #61
Comments
This work is largely done. I've built an example on my govCMS fork to illustrate how this will work: There are two example PRs:
To check out the environments and failure screenshot you'll need to add /etc/hosts records (the 'real' version should have a wildcard DNS record) :
Any submitted PRs will trigger a new environment to be built, whereby the govCMS codebase is built and tested against a merged codebase. The environments will persist, so a user will be able to login and test features or enhancements made in a pull request. If one of the tests fail, a screenshot will be taken (via a headless webkit browser) and be made accessible, making debugging issues easier. There are a few things that we need to build the 'final' version of this:
|
Probably unlikely that we'll be able to publish PR environments under a .gov.au domain - even if it does have "dev" in the name. Perhaps we buy govc.ms to run these does off? E.g. $ISSUE_ID.dev.govc.ms? This would probably also make it easier to obtain a wildcard SSL Certificate. For the bot, can we create a user? "govCMS Jenkins" or perhaps Jim? A nicely formated pass/fail post would be sufficient with a link to the build failure or site build. |
Yes we can create a regular GitHub user to be the bot - I'll need access to the user account to generate an appropriate token. We have a wildcard domain hooked up to the test environment now (thanks @typhonius), so there is no need for /etc/hosts records, and we can now post screenshots directly into the response comment from the bot (see https://github.com/srowlands/govCMS/pull/4) |
govCMS bot is up so I think we can close this one. @SRowlands++ |
When a PR is contributed to govCMS there are several loops it has to get through to get tested. The tester has to be able to:
For someone who is not technical, there are a lot of technical steps to make this happen. If we could automatically setup the PR in a testable environment then this would help us get more community members involved by being able to test changes without having requiring the technical skills necessary to build and host a govCMS site.
The text was updated successfully, but these errors were encountered: