Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll back up button #377

Open
Ainali opened this issue Apr 16, 2024 · 5 comments · May be fixed by #381
Open

Scroll back up button #377

Ainali opened this issue Apr 16, 2024 · 5 comments · May be fixed by #381
Labels
enhancement 🥇 New feature or request

Comments

@Ainali
Copy link
Member

Ainali commented Apr 16, 2024

The feature

As some of our pages are really long, especially country pages, it would be nice with a button that brings you back to the top on those.

Why?

It could save time and also increase accessibility somewhat. Also, implemented right it looks kind of cool.

Examples and inspiration

I stumbled upon this neat and dynamic solution using only CSS:

It shows the button only after have started scrolling down a bit. For us, it could be when you have scrolled past the country info box.

@Ainali Ainali added the enhancement 🥇 New feature or request label Apr 16, 2024
@Ainali Ainali linked a pull request May 3, 2024 that will close this issue
@MarcosApodaca
Copy link

I'm interested in adding this work to your website, I'm open to be assigned the case and I would be happy to solve it.

@Ainali
Copy link
Member Author

Ainali commented May 5, 2024

I'm interested in adding this work to your website, I'm open to be assigned the case and I would be happy to solve it.

@MarcosApodaca: There is already a PR for this issue (linked just above your comment). Your review on that one is welcome.

@MarcosApodaca
Copy link

I saw it, but in the web it is not implemented yet, enter in the section of countries, and when you scroll the names, the scroll does not appear to take you to the top of the page.

@RVA2869
Copy link
Contributor

RVA2869 commented May 5, 2024

but in the web it is not implemented yet

@MarcosApodaca
Because the PR has not yet been merged with the main branch....

@Ainali
Copy link
Member Author

Ainali commented May 5, 2024

@MarcosApodaca As RVA2869 said, it hasn't been merged yet. Which means that this is a great opportunity for you to set up your local environment, and switch to that branch and see if it works locally for you. That will give you a flying start for another issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🥇 New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants