Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back-to-top link #381

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add back-to-top link #381

wants to merge 1 commit into from

Conversation

Ainali
Copy link
Member

@Ainali Ainali commented May 3, 2024

Based on https://codepen.io/chriscoyier/pen/NWmzZXo

Fixes #377

(If #380 is merged, the tests will pass.)

@Ainali Ainali requested a review from Abbe98 May 3, 2024 14:09
@RVA2869
Copy link
Collaborator

RVA2869 commented May 3, 2024

Wouldn't it be better to add the <a href="#top" class="to-top-link">Back to top</a> in layout.html?

@Ainali
Copy link
Member Author

Ainali commented May 3, 2024

I considered that first but chose not to for two reasons:

  1. Most important, it would be outside the <main> tag.
  2. Less important, I think it is really only the country pages that require a lot of scrolling.

@RVA2869
Copy link
Collaborator

RVA2869 commented May 3, 2024 

2. Less important, I think it is really only the country pages that require a lot of scrolling.

And the topics pages. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abbe98 Abbe98 Awaiting requested review from Abbe98

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll back up button
2 participants
@Ainali @RVA2869