Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Icon menu background #49

Closed
Yaniqa opened this issue May 19, 2014 · 4 comments
Closed

Icon menu background #49

Yaniqa opened this issue May 19, 2014 · 4 comments

Comments

@Yaniqa
Copy link

Yaniqa commented May 19, 2014

Hi,

The background of my icon menu is not working correctly. It only shows two small white blocks at the beginning and the end of the menu.

Could this be fixed?

Best wishes,

Janneke

@devinsays
Copy link
Contributor

Yes, I got all three of your e-mails and responded. :)

The icon menu uses class "icon-menu-container", which causes issues if a third party plugin enqueues font-awesome due to their use of:

"[class^="icon-"], [class*=" icon-"]".

@lukefretwell We might want to update this on the theme side to "menu-icon-container" to avoid future conflicts with third party scripts and plugins.

@lukefretwell
Copy link
Member

+1

@ethanteague
Copy link
Contributor

@lukefretwell, and @devinsays, I've changed the codebase as suggested above, in this pull request:
#57

@devinsays
Copy link
Contributor

Thanks. Closing issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants