Skip to content

Commit

Permalink
[DO NOT MERGE]: try to reenable test that stresses golang/go#36144
Browse files Browse the repository at this point in the history
  • Loading branch information
myitcv committed Jan 16, 2020
1 parent 8b14428 commit 2e3fcdd
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 11 deletions.
6 changes: 1 addition & 5 deletions _scripts/dockerRun.sh
Expand Up @@ -45,11 +45,7 @@ export GOVIM_RUN_INSTALL_TESTSCRIPTS=true

go generate $(go list ./... | grep -v 'govim/internal/golang_org_x_tools')
go test $(go list ./... | grep -v 'govim/internal/golang_org_x_tools')

# if [ "${CI:-}" == "true" ] && [ "${TRAVIS_BRANCH:-}_${TRAVIS_PULL_REQUEST_BRANCH:-}" == "master_" ]
# then
go test -race $(go list ./... | grep -v 'govim/internal/golang_org_x_tools')
# fi
go test -race $(go list ./... | grep -v 'govim/internal/golang_org_x_tools')

go vet $(go list ./... | grep -v 'govim/internal/golang_org_x_tools')
go run honnef.co/go/tools/cmd/staticcheck $(go list ./... | grep -v 'govim/internal/golang_org_x_tools')
Expand Down
23 changes: 17 additions & 6 deletions cmd/govim/testdata/scenario_default/bug_gopls_36144.txt
Expand Up @@ -11,16 +11,27 @@
# cancellation of the initial diagnostics for the package, or the diagnostics
# that are sent when a file is opened.

skip 'Known issue reported as https://github.com/golang/go/issues/36144'

vim ex 'e main.go'
errlogmatch 'PublishDiagnostics callback: &protocol.PublishDiagnosticsParams{\n\S+:\s+URI:\s+"file://'$WORK/main.go
vimexprwait errors.golden getqflist()

-- go.mod --
module mod.com

-- main.go --
package main

func main() {
}
blah
-- errors.golden --
[
{
"bufnr": 2,
"col": 1,
"lnum": 3,
"module": "",
"nr": 0,
"pattern": "",
"text": "expected declaration, found blah",
"type": "",
"valid": 1,
"vcol": 0
}
]
2 changes: 2 additions & 0 deletions cmd/govim/testdata/scenario_default/references.txt
Expand Up @@ -3,6 +3,8 @@

[short] skip 'Skip short because we sleep for GOVIM_ERRLOGMATCH_WAIT to ensure we don''t have any errors'

skip 'Whilst we wait for the solution to https://github.com/golang/go/issues/36598'

# Initial location population
vim ex 'e main.go'
vim ex 'call cursor(15,24)'
Expand Down

0 comments on commit 2e3fcdd

Please sign in to comment.