Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/govim: create visual tests for popups #598

Open
myitcv opened this issue Nov 26, 2019 · 0 comments
Open

cmd/govim: create visual tests for popups #598

myitcv opened this issue Nov 26, 2019 · 0 comments
Labels
testing Testing
Milestone
Unplanned

Comments

@myitcv
Copy link
Member

myitcv commented Nov 26, 2019

At present we do not test for how popups are shown on screen.

This means that we miss cases where long lines of text might be invisible/inaccessible.

Fix this by creating tests for such edge cases where we visually snapshot what's actually shown to the user and lock in that behaviour. Vim has similar such tests, so probably use a similar sort of technique.
@myitcv myitcv added the testing Testing label Nov 26, 2019
@myitcv myitcv added this to the Unplanned milestone Nov 26, 2019
myitcv added a commit that referenced this issue Nov 26, 2019
@myitcv
cmd/govim: properly format messages that we are asked to show by gopls
fc9dad9 
* Render multi-line messages as such
* Wrap long lines of text (otherwise they get totally lost)

Tests for this are covered by #598
myitcv added a commit that referenced this issue Nov 27, 2019
@myitcv
cmd/govim: properly format messages that we are asked to show by gopls
c128bd0 
* Render multi-line messages as such
* Wrap long lines of text (otherwise they get totally lost)

Tests for this are covered by #598
myitcv added a commit that referenced this issue Dec 1, 2019
@myitcv
cmd/govim: properly format messages that we are asked to show by gopls (
2983b2f 
#599)

* Render multi-line messages as such
* Wrap long lines of text (otherwise they get totally lost)

Tests for this are covered by #598
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Testing
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
1 participant
@myitcv