-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update x/tools and gopls to 65435275 #1002
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this change also includes two other updates: - updates error message in test "scenario_modreadonly/config_set_env_goflags_mod_readonly" due to CL 274119. - gopls.go now explicitly sets "allowModfileModifications" to true, see CL 268597, 274532 & 275442. * gopls/internal/regtest: eliminate unneeded executions and reduce delay 65435275 * internal/lsp: move the background context onto the snapshot ab685790 * internal/lsp/source: allow users to set new options for network access 9a0e0bbb * internal/lsp: fix handling of //-style comments in CRLF files 73cf035b * internal/lsp/source: default experimentalDiagnosticsDelay to 250ms 6607ba8a * internal/lsp: force LANG setting while difftest a679dec0 * internal/lsp: separate the environment's value of GO111MODULE out 54578894 * internal/lsp: update diagnostic snapshotID even if not published 214da9f3 * tools, gopls: add pkg.go.dev badges to READMEs 39497347 * internal/lsp: move generated file check out of didModifyFiles fe8bd3ca * go/analysis/passes/fieldalignment: suggest fix for multi-named fields 090fee60 * gopls/doc: generate JSON too, store as composite literal a1a1cbea * internal/lsp/source: allow opt-out from -mod=readonly, GOPROXY=off fa6651ed * internal/lsp: add go get quick fix on failing imports bd5d160b * internal/lsp: disable network access for some go commands 43adb69d * internal/lsp: set -mod=readonly in most contexts 9bc6a978 * internal/lsp: add READMEs that describe tests, how to run tests bdde1628 * gopls/doc: fix link to lsp-go.el 8b44681d * internal/lsp: don't reload invalid build configurations unconditionally 2ecf2a5d * gopls/doc: add fieldalignment to analyzers.md bef1c476 * cmd/toolstash: drop 387, use softfloat instead 7534955a * gopls/internal/regtest: TestRenamePackage passes with go 1.16 92771a23 * internal/lsp: improve errors in multi-module workspaces (GO111MODULE=on) 7beb506c * internal/lsp: track all go.mod changes no matter the workspace mode a1b87a1c * internal/lsp/cache: include missing dependencies in mod tidy key 5fbf2908 * internal/lsp/cache: fix race on snapshot.workspaceDirHandle 182cd11f * internal/lsp: limit all findModules calls to search 1 million files ae829c33 * internal/lsp: run analyses on changed files before full diagnostics ac6f37ff * internal/lsp: use mode (GOPATH/modules) oriented error messages fd09bd90 * internal/lsp: check the value of GO111MODULE before collecting modules f0400ba2 * Change require 'nvim_lsp' to 'lspconfig' in vim.md 02d27ecf * internal/lsp: disable support for symlinks pending decision 1937afe4 * internal/lsp: only show gc_details diagnostics on saved buffers dcde6b0e * internal/lsp/lsprpc: prefer XDG_RUNTIME_DIR for the daemon socket 74704816 * internal/lsp: update modifications to directories at the LSP level 7e522c86 * internal/lsp: restore snapshot ID guard for published diagnostics bd313628 * Revert "internal/lsp/source: simplify workspace symbol package collection" bf23c547 * internal/lsp/source: simplify workspace symbol package collection 852eb642 * go/analysis: avoid panic in ifaceassert fd5f2936 * gopls, internal/lsp: support fillstruct for partially-filled structs 0e8b1ee1 * internal/lsp: offer type converted completion candidates ca1c1492 * Revert "internal/lsp: use mode (GOPATH/modules) oriented error messages" c5a73c30 * internal/lsp: use mode (GOPATH/modules) oriented error messages ccae4fb3 * internal/lsp: fix misspelling in Codelens option e7a54586 * internal/lsp: move options to correct sections b5590dee * internal/lsp: explicitly watch all known directories 2e53cd67 * go/analysis/passes/fieldalignment: add fieldalignment analyser 299f270d * internal/lsp: extract filenames from go command errors d890b968 * internal/lsp: switch the default symbol style to dynamic 208275ba * internal/lsp: rewrite the workspace symbol marker tests 325b08a5 * internal/lsp/tests: factor normalization logic out of cmd tests ed677e9d * internal/lsp: track diagnostics by reporting source a3098589 * internal/lsp: revise some semantic token details a9663296 * internal/lsp: fix some incorrect spelling 2c860bdd * gopls/internal/regtest: skip regtests for openbsd-amd64-64 on TryBots 911501bf * internal/lsp: fix title for vendor suggested fix 4aa1a224 * internal/lsp: only show command errors once a83918f9 * gopls/internal/regtest: convert circular import tests to regtests b5535b15 * internal/lsp: use pointers to source.Error, and not to ErrorList db3e1ec2 * internal/lsp: refactor code action go command calls a9763abb * internal/lsp: fix godef for embedded type aliases 5bad4594 * internal/lsp: nest the workspace root if there is only one module 45586ddb * internal/lsp: fix go.mod parse error parsing to show diagnostics 780cb80b * internal/lsp: remove workspace packages as needed 20be4ac4 * internal/lsp/cache: only invalidate metadata for go.mod files on save 6d151481 * internal/lsp: pass a parsed module to go mod tidy a7380940 * internal/lsp/fake: hold the mutex for all of SaveBufferWithoutActions c0d5e891 * gopls/internal/regtest: handle flake in TestCRLF be796f87 * internal/lsp/source: set experimentalPackageCacheKey to true by default 0557df36 * Handle BareInits option in ssa.BuilderMode 4783bc9b * internal/lsp: handle deletion of a directory on disk 25dc3e1c * internal/lsp/mod: speed up and simplify go.mod code lenses 4d9c4f8a * internal/lsp/cache: fix a staticcheck warning by handling error 1727ee11 * internal/lsp: support unimported completions in multi-module mode 6ed8ff9a
0af2827
to
4602fc0
Compare
myitcv
approved these changes
Dec 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this change also includes two other updates:
Updates error message in test "scenario_modreadonly/config_set_env_goflags_mod_readonly" due to CL 274119.
gopls.go now explicitly sets "allowModfileModifications" to true, see CL 268597, 274532 & 275442.