cmd/govim: do not wait more than 500ms for gopls Shutdown #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As explained in golang.org/issue/45476, all call to Shutdown does not properly interrupt "work" that might be in progress in gopls. This has the effect of blocking an exit from Vim. Workaround this for now by limiting the wait time to 500ms, which is effectively the measure of a user's patience before anger/frustration sets in!
|
cc @mvdan |
|
Sounds good to me. I'd even find 1s acceptable, but anything beyond that definitely not :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in golang.org/issue/45476, all call to Shutdown does not
properly interrupt "work" that might be in progress in gopls. This has
the effect of blocking an exit from Vim.
Workaround this for now by limiting the wait time to 500ms, which is
effectively the measure of a user's patience before anger/frustration
sets in!