testdriver: fix data race introduced in #1101 #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leitzler
force-pushed
the
testdriver-race
branch
2 times, most recently
from
eeaa394
to
9265905
Compare
leitzler
force-pushed
the
testdriver-race
branch
2 times, most recently
from
5a0756f
to
f962214
Compare
With #1101 a data race was accidentally introduced where the global testsetup.VimCommand was overwritten. We now make a local copy that is modified instead. Fixing this revealed that #1101 wasn't enough. Testscript conditions that matches a vim version also used the testscript subcommand instead of real vim. It now uses the real vim. Closes #1104
leitzler
force-pushed
the
testdriver-race
branch
from
f962214
to
3b0a833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #1101 was merged I accidentally introduced a data race by modifying
the global VimCommand. We now make a local copy that is modified
instead.
Closes #1104