cmd/govim: support multi-lined diagnostics in hover #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type parameter support in gotip has a few diagnostics that is multi-lined. We now properly show them in hover popups as multiple lines, and appends the source to the first line only.
myitcv
reviewed
Sep 23, 2021
myitcv
approved these changes
Sep 23, 2021
|
Yes, tested locally. Tried to find any multi-lined diagnostics pre-Go1.18 to add as test but only found type parameter related ones :( |
|
Wrote #1111 as a reminder to myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type parameter support in gotip has a few diagnostics that is
multi-lined. We now properly show them in hover popups as multiple
lines, and appends the source to the first line only.