cmd/govim: fix ftplugin approach #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
cmd_govim_fix_ftplugin_mess
branch
2 times, most recently
from
eb096ff
to
3e43000
Compare
Having Vim callback into govim in order to simply run a bunch of mappings is overkill. Not least because the user would end up having to "translate" the Go calls to VimScript in order to override the mappings in their own ~/.vim/after/ftplugin/go.vim file. So, simplify everything by just using VimScript here. Fixes #181
myitcv
force-pushed
the
cmd_govim_fix_ftplugin_mess
branch
from
3e43000
to
463e884
Compare
myitcv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having Vim callback into govim in order to simply run a bunch of
mappings is overkill. Not least because the user would end up having to
"translate" the Go calls to VimScript in order to override the mappings
in their own ~/.vim/after/ftplugin/go.vim file.
So, simplify everything by just using VimScript here.
Fixes #181