Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/govim: temporary implementation of file watching #189

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Apr 30, 2019

For now use textDocument/didOpen and textDocument/didChange to deal with
generated files changing, whilst we await a proper implementation in
gopls via golang/go#31553.

@myitcv
Copy link
Member Author

myitcv commented Apr 30, 2019

Currently blocked on golang/go#31759; although we could rework the tests to workaround the test failure. It is a legitimate test failure however.

@myitcv myitcv force-pushed the cmd_govim_watch_files branch 4 times, most recently from 832ffd5 to a222541 Compare April 30, 2019 18:43
@myitcv myitcv changed the title [WIP] cmd/govim: temporary implementation of file watching cmd/govim: temporary implementation of file watching Apr 30, 2019
For now use textDocument/didOpen and textDocument/didChange to deal with
generated files changing, whilst we await a proper implementation in
gopls via golang/go#31553.
@myitcv myitcv merged commit af25fed into master Apr 30, 2019
@myitcv myitcv deleted the cmd_govim_watch_files branch April 30, 2019 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant