cmd/govim: fix completion #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://go-review.googlesource.com/c/tools/+/176958 changed the TextEdits returned from gopls to not be the trimmed version of the label. This meant that we were effectively appending the entire completion text after the prefix. This wasn't caught in the completion tests because there we were attempting a "naked" completion with no prefix. Fix by fixing the test (which confirmed the bug) then fixing the results returned from gopls. Seemingly, a list of completion items from gopls can specify a start position per item. This does not appear to be supported by Vim (see :help complete-functions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://go-review.googlesource.com/c/tools/+/176958 changed the
TextEdits returned from gopls to not be the trimmed version of the
label. This meant that we were effectively appending the entire
completion text after the prefix.
This wasn't caught in the completion tests because there we were
attempting a "naked" completion with no prefix.
Fix by fixing the test (which confirmed the bug) then fixing the results
returned from gopls.
Seemingly, a list of completion items from gopls can specify a start
position per item. This does not appear to be supported by Vim (see
:help complete-functions)