Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/govim: add a test that verifies things generally work for cgo #429

Merged
merged 1 commit into from
Feb 11, 2020
Merged

cmd/govim: add a test that verifies things generally work for cgo #429

merged 1 commit into from
Feb 11, 2020

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Jul 30, 2019

No description provided.

@myitcv myitcv mentioned this pull request Jul 30, 2019
Open
@myitcv myitcv added the onhold Probably pending some 3rd party issue label Sep 24, 2019
@myitcv myitcv force-pushed the cmd_govim_cgo_example branch 2 times, most recently from b47f75c to a94021d Compare December 2, 2019 12:37
@myitcv myitcv force-pushed the cmd_govim_cgo_example branch 7 times, most recently from f85aeba to d5dab08 Compare December 12, 2019 11:48
@myitcv myitcv force-pushed the cmd_govim_cgo_example branch 4 times, most recently from 9995a45 to 0cb2e4b Compare December 16, 2019 12:12
@myitcv myitcv force-pushed the cmd_govim_cgo_example branch 2 times, most recently from 5aeb50d to 1969661 Compare December 22, 2019 15:43
@myitcv myitcv force-pushed the cmd_govim_cgo_example branch 3 times, most recently from 1e7eeab to 6273445 Compare January 29, 2020 12:26
@myitcv myitcv force-pushed the cmd_govim_cgo_example branch 5 times, most recently from 2f27f4a to 73b59d6 Compare February 1, 2020 08:22
@myitcv myitcv force-pushed the cmd_govim_cgo_example branch 2 times, most recently from 5cda186 to c27baa8 Compare February 10, 2020 14:54
@myitcv myitcv changed the title [WIP] cmd/govim: add a test that verifies things generally work for cgo cmd/govim: add a test that verifies things generally work for cgo Feb 10, 2020
@myitcv myitcv requested a review from leitzler February 10, 2020 15:12
leitzler
leitzler approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another go.mod comment, otherwise LGTM

cmd/govim/testdata/scenario_default/cgo_support.txt Show resolved Hide resolved
@myitcv
cmd/govim: add a test that verifies things generally work for cgo
d4ca772 
Pending golang.org/issues/35721, this test is skipped.
@myitcv myitcv merged commit 44ba56e into master Feb 11, 2020
@myitcv myitcv deleted the cmd_govim_cgo_example branch February 11, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leitzler leitzler leitzler approved these changes

Assignees
No one assigned
Labels
onhold Probably pending some 3rd party issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@myitcv @leitzler