cmd/govim: de-dupe quickfix diagnostics and retain selected index #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
dedupe_quickfix_diagnostics
branch
from
b7a5b93
to
a1b104e
Compare
myitcv
force-pushed
the
dedupe_quickfix_diagnostics
branch
from
a1b104e
to
b3eb367
Compare
leitzler
reviewed
Sep 4, 2019
leitzler
approved these changes
Sep 4, 2019
Currently, because of golang/go#32443 we can unnecessarily update the quickfix window with diagnostics. What's more, when we update the quickfix list we lose the selected index; the first row is selected when the quickfix list is reset. This presents something of a problem when jumping to a quickfix error in a file that is not currently open, where that error is not the first in the quickfix list. Because jumping to that error means we trigger a didOpen, which triggers all diagnostics to be sent again (even though they haven't changed), which causes the first row to be selected again. The user, understandably, get's very confused. So for now, we use reflect.DeepEqual to de-dupe the diagnostics we receive from gopls, pending a fix to golang/go#32443. We also keep track of the last set error diagnostics, so that when setting new diagnostics we can reselect the currently selected row. Or, if that row no longer exists, select the first row. This changes the times that setqflist is called. Hence, fix up tests which previously asserted based on this behaviour. As part of this change we also retrigger clearing/population of the quickfix list (and signs) as the relevant config changes. Also slightly optimise the sign placement code to return early if signs are disabled.
myitcv
force-pushed
the
dedupe_quickfix_diagnostics
branch
from
b3eb367
to
be38c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.