cmd/govim: place signs for existing diagnostics in new buffers #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leitzler
force-pushed
the
cmd_govim_signs_for_known_diags
branch
from
0a2c522
to
7f6067a
Compare
|
I moved the new test to a separate file, since it seems like changing the entire buffer often trigger #591 (previously it was a part of signs.txt but with a separate main.go). |
myitcv
approved these changes
Nov 23, 2019
If gopls report diagnostics for files that aren't opened in vim they won't get any signs placed when they are opened. A typical use case is when staticcheck report diagnostics for a file that isn't opened, and the user uses quickfix to jump directly to the issue (effectively opening a new buffer). This change updates the internal diagnostics cache when a buffer is read or closed so existing diagnostics will have signs placed.
leitzler
force-pushed
the
cmd_govim_signs_for_known_diags
branch
from
7f6067a
to
b416a3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If gopls report diagnostics for files that aren't opened in vim
they won't get any signs placed when they are opened.
A typical use case is when staticcheck report diagnostics for
a file that isn't opened, and the user uses quickfix to jump
directly to the issue (effectively opening a new buffer).
This change updates the internal diagnostics cache when a buffer
is read or closed so existing diagnostics will have signs placed.