cmd/govim: put install scripts tests behind env var #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
cmd_govim_install_scripts_behind_env_var
branch
from
2872206
to
408ef59
Compare
Currently we skip long-running tests when running go test with -short. This is standard practice. But as part of efforts to add the govim test suite to the gopls integration tests: https://go-review.googlesource.com/c/tools/+/212018 we now need to distinguish between all long running tests and those long running tests that are install/network related. Hence we now only run install script tests when GOVIM_RUN_INSTALL_TESTSCRIPTS=true. Fixes #631
myitcv
force-pushed
the
cmd_govim_install_scripts_behind_env_var
branch
from
408ef59
to
9b47e7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @findleyr