testing: revert GOTMPDIR hack for setting testscript workdir root #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
tests_revert_hack_for_workdir_root
branch
from
e9fd009
to
4cb7224
Compare
In 854efae we included a temporary hack for setting the destination of artefacts for testscript tests, via GOTMPDIR. In this commit we undo that hack. Motivation for the change best described in: rogpeppe/go-internal@bc89b17
myitcv
force-pushed
the
tests_revert_hack_for_workdir_root
branch
from
4cb7224
to
eeddee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 854efae we included a temporary hack for setting the destination of
artefacts for testscript tests, via GOTMPDIR. In this commit we undo
that hack.
Motivation for the change best described in:
rogpeppe/go-internal@bc89b17