Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/govim: test diagnostics in directory replaced dependencies #738

Merged
merged 1 commit into from
Jan 30, 2020
Merged

cmd/govim: test diagnostics in directory replaced dependencies #738

merged 1 commit into from
Jan 30, 2020

Conversation

leitzler
Copy link
Member

No description provided.

@leitzler leitzler force-pushed the cmd_govim_add_replace_edit_test branch from 6d34c10 to 003a2d3 Compare January 29, 2020 11:41
@leitzler leitzler changed the title [WIP] cmd/govim: test diagnostics in locally replaced dependencies cmd/govim: test diagnostics in locally replaced dependencies Jan 29, 2020
@leitzler leitzler requested a review from myitcv January 29, 2020 11:41
@leitzler leitzler force-pushed the cmd_govim_add_replace_edit_test branch from 003a2d3 to ac57a5d Compare January 29, 2020 12:17
myitcv
myitcv approved these changes Jan 30, 2020
View reviewed changes
Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small comments, otherwise LGTM

cmd/govim/testdata/scenario_default/quickfix_replaced_dep.txt Outdated Show resolved Hide resolved
cmd/govim/testdata/scenario_default/quickfix_replaced_dep.txt Outdated Show resolved Hide resolved
cmd/govim/testdata/scenario_default/quickfix_replaced_dep.txt Outdated Show resolved Hide resolved
cmd/govim/testdata/scenario_default/quickfix_replaced_dep.txt Outdated Show resolved Hide resolved
@leitzler leitzler force-pushed the cmd_govim_add_replace_edit_test branch from ac57a5d to ff3609d Compare January 30, 2020 14:35
@leitzler leitzler changed the title cmd/govim: test diagnostics in locally replaced dependencies cmd/govim: test diagnostics in directory replaced dependencies Jan 30, 2020
@leitzler
cmd/govim: test introducing diagnostics in directory replaced depende…
4a01d02 
…ncies

When using a directory replaced dependency it isn't monitored by gopls,
see https://golang.org/issues/36745.

This change adds a test that verifies that we do get diagnostics from
gopls when introducing errors in a directory replaced dependency.
@leitzler leitzler force-pushed the cmd_govim_add_replace_edit_test branch from ff3609d to 4a01d02 Compare January 30, 2020 19:52
@leitzler leitzler merged commit 484c2d1 into master Jan 30, 2020
@leitzler leitzler deleted the cmd_govim_add_replace_edit_test branch January 30, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myitcv myitcv myitcv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leitzler @myitcv