cmd/govim: move unimported completion tests to scenario_default #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
cmd_govim_move_complete_unimported_tests
branch
from
f3e7127
to
e41a816
Compare
leitzler
approved these changes
Feb 23, 2020
The default for the unimported completions config option in gopls (and govim) switched to be "on" some time ago. Hence we do not need a special scenario for the corresponding tests, and can move them to scenario_default. Also make a couple of documentation tweaks to make clear default values.
myitcv
force-pushed
the
cmd_govim_move_complete_unimported_tests
branch
from
e41a816
to
39348ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.