cmd/govim: safely handle busy state changes for non-.go buffers #823
+69
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myitcv
force-pushed
the
cmd_govim_only_set_busy_on_go_files
branch
from
ea103e4
to
a73d2f0
Compare
In 8926dec we backed out the changes for tracking all buffer changes. But in so doing we didn't properly handle the situation where the busy state changes and the cursor is in a non-go file. Fix that and add a test to verify we don't regress. Whilst we are at it: * consistently use GOVIM_test_SetUserBusy in our testscript tests * slightly refactor the types/consts used for getting the current cursor position Fixes #821
myitcv
force-pushed
the
cmd_govim_only_set_busy_on_go_files
branch
from
a73d2f0
to
a44bb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 8926dec we backed out the changes for tracking all buffer changes.
But in so doing we didn't properly handle the situation where the busy
state changes and the cursor is in a non-go file.
Fix that and add a test to verify we don't regress.
Whilst we are at it:
position
Fixes #821