Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/govim: fix index out of range bug when flipping back to diagnostics #840

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented Apr 2, 2020

See the description in the linked issue.

Fixes #680

@myitcv myitcv requested a review from leitzler April 2, 2020 14:23
@myitcv myitcv force-pushed the cmd_govim_fix_quickfix_index_bug branch from 870940f to 8fda179 Compare April 2, 2020 14:56
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some naming thoughts, otherwise LGTM

cmd/govim/quickfix.go Show resolved Hide resolved
cmd/govim/quickfix.go Outdated Show resolved Hide resolved
@myitcv myitcv force-pushed the cmd_govim_fix_quickfix_index_bug branch from 8fda179 to 9065971 Compare April 7, 2020 16:51
@myitcv myitcv merged commit 0e9dda5 into master Apr 7, 2020
@myitcv myitcv deleted the cmd_govim_fix_quickfix_index_bug branch April 7, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cmd/govim: panic handling GOVIMQuickfixDiagnostics
2 participants