Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/govim: only doautoall on govim events #871

Merged
merged 1 commit into from
May 11, 2020

Conversation

myitcv
Copy link
Member

@myitcv myitcv commented May 10, 2020

No description provided.

@myitcv myitcv requested a review from leitzler May 10, 2020 18:46
@myitcv myitcv force-pushed the cmd_govim_more_conservative_doautoall branch 2 times, most recently from 9d656cd to 874062c Compare May 11, 2020 05:11
Copy link
Member

@leitzler leitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This means we don't unnecessarily trigger other autocommands for a
situation where we only need to trigger govim events once the plugin has
loaded.
@myitcv myitcv force-pushed the cmd_govim_more_conservative_doautoall branch from 874062c to 5b2b12c Compare May 11, 2020 09:13
@myitcv myitcv merged commit 8dbe91b into master May 11, 2020
@myitcv myitcv deleted the cmd_govim_more_conservative_doautoall branch May 11, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants