Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update x/tools and gopls to 25775e59acb7 #899

Merged
merged 1 commit into from
Jun 25, 2020
Merged

deps: update x/tools and gopls to 25775e59acb7 #899

merged 1 commit into from
Jun 25, 2020

Conversation

leitzler
Copy link
Member

  • internal/memoize: add an error return to (*handle).Get 25775e59
  • internal/jsonrpc2: omit empty error data dcbf2a9e
  • internal/lsp/analysis/fillstruct: add indentation for struct fields f8e0ea3a
  • internal: fill struct with initialized values instead of nil values 456ad74e
  • internal/lsp: refactor various module-specific handles in cache 1745ac5b
  • gopls/integration: fix typo aloso => also ff88973b
  • internal/lsp: don't use -modfile for go mod commands 20e05c1c
  • internal/lsp/cache: fix ignored file check 4fd1c644
  • internal/jsonrpc2: don't set result in response if there is an error fcc5b64f

@leitzler
deps: update x/tools and gopls to 25775e59acb7
7e13e62 
* internal/memoize: add an error return to (*handle).Get 25775e59
* internal/jsonrpc2: omit empty error data dcbf2a9e
* internal/lsp/analysis/fillstruct: add indentation for struct fields f8e0ea3a
* internal: fill struct with initialized values instead of nil values 456ad74e
* internal/lsp: refactor various module-specific handles in cache 1745ac5b
* gopls/integration: fix typo aloso => also ff88973b
* internal/lsp: don't use -modfile for `go mod` commands 20e05c1c
* internal/lsp/cache: fix ignored file check 4fd1c644
* internal/jsonrpc2: don't set result in response if there is an error fcc5b64f
@leitzler leitzler requested a review from myitcv June 25, 2020 05:34
myitcv
myitcv approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@myitcv myitcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@leitzler leitzler merged commit c535003 into master Jun 25, 2020
@leitzler leitzler deleted the deps_25775e59acb7 branch June 25, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myitcv myitcv myitcv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@leitzler @myitcv