Merge pull request #4267 from govuk-one-login/AUT-2597-Perf-Test-Thro…

…ttling-of-several-Lambda-functions Adding lifecycle ignore for provisioned_concurrent_executions
govuk-one-login · May 13, 2024 · e37f41c · e37f41c
2 parents 954e319 + 0270789
commit e37f41c
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/ci/terraform/account-management/authorizer.tf b/ci/terraform/account-management/authorizer.tf
@@ -77,6 +77,11 @@ resource "aws_lambda_provisioned_concurrency_config" "endpoint_lambda_concurrenc
   qualifier     = aws_lambda_alias.authorizer_alias.name
 
   provisioned_concurrent_executions = local.authorizer_provisioned_concurrency
+
+  lifecycle {
+    ignore_changes = [provisioned_concurrent_executions] # Ignoring as this is targeted by aws_app_autoscaling_target.lambda_target resource
+  }
+
 }
 
 resource "aws_appautoscaling_target" "lambda_target" {

diff --git a/ci/terraform/modules/endpoint-module/lambda.tf b/ci/terraform/modules/endpoint-module/lambda.tf
@@ -76,6 +76,11 @@ resource "aws_lambda_provisioned_concurrency_config" "endpoint_lambda_concurrenc
   qualifier     = aws_lambda_alias.endpoint_lambda.name
 
   provisioned_concurrent_executions = var.provisioned_concurrency
+
+  lifecycle {
+    ignore_changes = [provisioned_concurrent_executions] # Ignoring as this is targeted by aws_app_autoscaling_target.lambda_target resource
+  }
+
 }
 
 resource "aws_appautoscaling_target" "lambda_target" {

diff --git a/ci/terraform/modules/stub-endpoint-module/lambda.tf b/ci/terraform/modules/stub-endpoint-module/lambda.tf
@@ -76,6 +76,11 @@ resource "aws_lambda_provisioned_concurrency_config" "endpoint_lambda_concurrenc
   qualifier     = aws_lambda_alias.endpoint_lambda.name
 
   provisioned_concurrent_executions = var.provisioned_concurrency
+
+  lifecycle {
+    ignore_changes = [provisioned_concurrent_executions] # Ignoring as this is targeted by aws_app_autoscaling_target.lambda_target resource
+  }
+
 }
 
 resource "aws_appautoscaling_target" "lambda_target" {

diff --git a/ci/terraform/utils/email_check_results_writer_lambda.tf b/ci/terraform/utils/email_check_results_writer_lambda.tf
@@ -74,6 +74,11 @@ resource "aws_lambda_provisioned_concurrency_config" "endpoint_lambda_concurrenc
   qualifier     = aws_lambda_alias.email_check_results_writer_lambda.name
 
   provisioned_concurrent_executions = var.email_check_results_writer_provisioned_concurrency
+
+  lifecycle {
+    ignore_changes = [provisioned_concurrent_executions]
+  }
+
 }
 
 resource "aws_cloudwatch_log_group" "lambda_log_group" {