OLH-1717 Set nvmrc version based on Dockerfile #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenciso
force-pushed
the
OLH-1717-update-nvmrc
branch
2 times, most recently
from
70f47ad
to
258534d
Compare
aenciso
changed the title
aenciso
force-pushed
the
OLH-1717-update-nvmrc
branch
from
258534d
to
052c163
Compare
aenciso
force-pushed
the
OLH-1717-update-nvmrc
branch
3 times, most recently
from
016249c
to
91b0892
Compare
aenciso
force-pushed
the
OLH-1717-update-nvmrc
branch
from
dbc20a4
to
7830377
Compare
saralk
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
OLH-1717 Set nvmrc version based on Dockerfile
What changed
Added a new workflow to run everytime dependabot updates the Dockerfile
Why did it change
Since Dependabot only updates node versions in our Dockerfiles, it is easier to keep .nvmrc file up to date once dependabot creates a PR that updates node
The workflow would only update .nvmrc if both node versions are different, making it easier to maintain rather than having build environment variables in our dockerfile and github actions. (See previous PR)
Related links
#1417
Checklists
Testing
I have modified the Dockerfile on a separate draft PR and how checked the workflow updates the .nvmrc file and creates a new PR
How to review