OLH-1828 - Upgrade the frontend to AWS SDK v3 #1457
+822
−3,528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aenciso
approved these changes
Jun 19, 2024
peterfajemisincabinetoffice
force-pushed
the
OLH-1828
branch
3 times, most recently
from
7eb2f61
to
2ec12a1
Compare
peterfajemisincabinetoffice
force-pushed
the
OLH-1828
branch
from
2ec12a1
to
dc0c934
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
OLH-1828 - Upgrade the frontend to AWS SDK v3
What changed
Removed aws-sdk 2.0 dependency from package.json and use modular implementations of the individual components we use in OLH. Also some code changes to align with new implementations
Why did it change
AWS SDK Version 2.x has reached end of support.
Related links
https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/welcome.html
https://docs.aws.amazon.com/sdk-for-javascript/v3/developer-guide/migrating.html
https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/
https://aws.amazon.com/blogs/developer/why-and-how-you-should-use-aws-sdk-for-javascript-v3-on-node-js-18/
Checklists
Thorough testing specifically in the areas of KMS, OIDC, S3 etc.
Environment variables or secrets
Testing
Deploy to dev and carry out an end to end test of all key functionalities
How to review
Code completeness and to detect breaking fixes