Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OLH-1849 Call the new API when a user adds a phone number as a backup… #1461

Conversation

aenciso
Copy link
Contributor

@aenciso aenciso commented Jun 20, 2024

Proposed changes

OLH-1849 When a user adds a phone number as their backup MFA method our frontend needs to make the appropriate request to the MFA methods API, including the data about their new method.

What changed

Added a new method call to the stubs api

Why did it change

Because it wasn't implemented

Related links

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed
  • Application configuration is up-to-date
  • Documented in the README
  • Added to deployment steps
  • Added to local startup config

Testing

Tested locally and in development

How to review

Checkout branch and test adding a backup method locally. User should get a confirmation screen

@aenciso aenciso force-pushed the OLH-1849-Call-the-new-API-when-a-user-adds-a-phone-number-as-a-backup-MFA-method branch 6 times, most recently from 868a5e5 to 01ed0a6 Compare June 21, 2024 21:04
@aenciso aenciso marked this pull request as ready for review June 24, 2024 11:53
@aenciso aenciso requested a review from a team as a code owner June 24, 2024 11:53
@aenciso aenciso force-pushed the OLH-1849-Call-the-new-API-when-a-user-adds-a-phone-number-as-a-backup-MFA-method branch from 01ed0a6 to ad3ed7a Compare June 25, 2024 12:32
@aenciso aenciso enabled auto-merge June 25, 2024 12:32
@aenciso aenciso force-pushed the OLH-1849-Call-the-new-API-when-a-user-adds-a-phone-number-as-a-backup-MFA-method branch from ad3ed7a to a521dda Compare June 25, 2024 12:44
@aenciso aenciso added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit d210039 Jun 25, 2024
8 checks passed
@aenciso aenciso deleted the OLH-1849-Call-the-new-API-when-a-user-adds-a-phone-number-as-a-backup-MFA-method branch June 25, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants