PYIC-6710: exclude secrets from process cri callback #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebauSoftwire
force-pushed
the
PYIC-6710-remove-secrets-in-contract-tests
branch
from
23d2c17
to
52ad495
Compare
thebauSoftwire
force-pushed
the
PYIC-6710-exclude-secrets-from-process-cri-callback
branch
from
6b4f4e5
to
4ef2323
Compare
thebauSoftwire
changed the base branch from
PYIC-6710-remove-secrets-in-contract-tests
to
PYIC-6710
thebauSoftwire
commented
Jun 20, 2024
| @@ -115,7 +115,8 @@ | |||
| "pattern": [ | |||
| "(?i)dummyapikey", | |||
| "(?i)test-secret", | |||
| "^x-api-key$" | |||
| "^x-api-key$", | |||
| "^1f9d73167e2166b707c6$" | |||
There was a problem hiding this comment.
Same comment as here: #2036 (comment)
|
sam803
previously approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
process-cri-callbackWhy did it change
The .secrets.baseline file was being updated with new secrets every time a "secret" was detected. Instead, we should use rules to avoid false positives being added to the baseline. This means we'll have less conflicts as the only changes made to the baseline should be if the filters are updated.
Issue tracking