PYIC-6870: Remove coiEnabled flag and redundant contexts #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wynndow
force-pushed
the
pyic-6870-remove-coi-ff
branch
2 times, most recently
from
73d5c40
to
55274f3
Compare
This removes the use of the coiEnabled feature flag in the journey maps. We've been able to drop a couple of states because of this. There are also some now unneccessary contexts which can also be removed. This also adds a new event to the `IDENTITY_REUSE_PAGE_TEST` state. This is to get the tests to pass. We test that page states all have the same events defined on them. The removal of the flag tripped the test up. This state is a test state for a feature we aren't using, so I've just routed to the technical error page. There will be a fronend-change which should be merged before this. f
The orphaned states option wasn't working. When it was created it specifically excluded the initial journey state from it's output, as it legitimately had no events pointing at it. This was one we had just one map though. Now we've split the map, we have lots of "start" states. Keeping track of and excluding them would be hard. This option is still useful, as it's easy to see which states are legitimate once applied, highlighting any erroneous states.
Wynndow
force-pushed
the
pyic-6870-remove-coi-ff
branch
from
55274f3
to
1663fb4
Compare
|
Joe-Edwards-GDS
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
What changed
Remove coiEnabled flag and redundant contexts
Why did it change
This removes the use of the coiEnabled feature flag in the journey maps. We've been able to drop a couple of states because of this.
There are also some now unneccessary contexts which can also be removed.
There will be a fronend-change which should be merged before this.
Issue tracking