Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add swiftlint step to runner #152

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

jdubey
Copy link
Contributor

@jdubey jdubey commented Jun 19, 2024

DCMAW-9252 add swiftlint install to runner

Adding swiftlint install to see if it helps with deploy problems

Checklist

Before raising your pull request:

  • Commit messages that conform to conventional commit messages
  • Ran the app locally ensuring it builds
  • Ran the tests locally ensuring they pass on Build
  • Pull request has a clear title with a short description about the feature or update
  • Created a draft pull request if it is not yet ready for review

Before your pull request can be reviewed:

  • Met all of the acceptance criteria specified in the user story on Jira

  • Reviewed your own code to ensure you are following the style guidelines

  • Ran the app and tested the feature on a range of device sizes
    Please include iPod Touch, iPhone SE and iPhone 11 as a minimum.

  • Written Unit and Integration tests if needed

  • Met all accessibility requirements?

    • Checked dynamic type sizes are applied
    • Checked VoiceOver can navigate your new code
    • Checked a user can navigate only using a keyboard around your new code

Before merging your pull request:

  • Ensure that the code coverage and SonarCloud checks have passed
  • Actioned and resolved all comments, reaching out to reviewers for clarifications if necessary.
  • Ran the app to ensure that no regressions have been caused by changes during code review.

@jdubey jdubey requested a review from a team as a code owner June 19, 2024 13:15
Copy link

sonarcloud bot commented Jun 19, 2024

@jdubey jdubey merged commit e5e4b3e into develop Jun 26, 2024
2 checks passed
@DylanRJ DylanRJ deleted the fix/dcmaw-9252-add-swiftlint branch July 3, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants