Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFC-429 Add language toggle feature #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

di-fabs
Copy link
Contributor

@di-fabs di-fabs commented Mar 6, 2024

What?

  • Add a new shared component called one login language toggle
  • So I had to change:
  • add a new feature flag in the env file called language_toggle
  • change the build-sass command
  • create a new middleware function for the creation of 2 new local variables
  • add the new nunjuck component into the base file.

Why?

Add language toggle feature

Please include reason for the change and any other relevant context.

Change have been demonstrated

Changes to the user interface or content should be demonstrated to Content Design and Interaction Design before being merged. This is to ensure they can make any necessary changes to Figma.

  • Changes to the user interface have been demonstrated

Delete this section if the PR does not change the UI.

Performance Analysis have been informed of the change

  • Performance Analysis have been informed of the change

Related PRs

Please include links to PRs in other repositories relevant to this PR.
Delete this section if not needed.

@di-fabs di-fabs changed the title DRAFT: DFC-429 Add language toggle feature DFC-429 Add language toggle feature Mar 12, 2024
@di-fabs di-fabs marked this pull request as ready for review March 12, 2024 15:01
@di-fabs di-fabs requested a review from a team as a code owner March 12, 2024 15:01
Copy link

sonarcloud bot commented Apr 2, 2024

@di-fabs di-fabs force-pushed the dfc-429-add-language-toggle branch from 2618997 to 957e6e4 Compare May 13, 2024 09:23
@di-fabs di-fabs force-pushed the dfc-429-add-language-toggle branch from 89e9b64 to 3543e0f Compare May 13, 2024 13:49
Copy link

sonarcloud bot commented May 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant