Ato 469/update deploy dev resources #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanmills
reviewed
May 10, 2024
isaac-GDS
force-pushed
the
ATO-469/update-deploy-dev-resources
branch
from
74f87c6
to
b973bd9
Compare
hannah-leong
reviewed
Jun 6, 2024
billrdunn
reviewed
Jun 18, 2024
billrdunn
reviewed
Jun 18, 2024
billrdunn
previously approved these changes
Jun 18, 2024
- added new provision_dev script - excluded dev specific ECR stack in provision_all script as it will cause error from naming - provision_dev script should be a temporary script until we move dev into our own account.
isaac-GDS
force-pushed
the
ATO-469/update-deploy-dev-resources
branch
from
185ffb8
to
39a1ca0
Compare
|
billrdunn
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
switched sandpit to dev
Add ECR for Dev in the gds-di-development account. Added script to deploy custom named dev-platform resource due to the account already having a dev-platform ECR.
This should be temporary while the dev environment