Fix Markdown and Storybook docs, remove ListNavigation #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1019 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 113 113
Lines 854 855 +1
Branches 233 233
=======================================
+ Hits 847 848 +1
Misses 7 7
Continue to review full report at Codecov.
|
As it's just a util for combining unordered list and wrapping children in ListItem, which is better done manually by the parent app
This was referenced Oct 6, 2021
Merged
penx
changed the title
penx
added a commit
that referenced
this pull request
Oct 7, 2021
## Significant changes This release is mainly about finishing the conversion to TypeScript and publishing types. A few things were removed in the process, hence the version bump: - Remove ListNavigation (#1019) - Remove @govuk-react/storybook-components (#1005) - Remove deprecate HOC (#980) ## Other changes of note - Remove use of PropTypes (#978) - Build using preconstruct, Export and Publish types (#992) - Move from storybook knobs to storybook controls (#1017) - Note on GlobalStyle and CSS reset in readme (#1038) - Migrate from Lerna to yarn 2 (#850, #1039)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958