Set storybook to be based on light theme #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If your OS (such as macOS) is set to use the dark theme, some browsers pass this through to Storybook which will then use the dark theme as default. This means components will then not have a white background when viewing within Storybook. This commit set the base theme to be the 'light' Storybook theme, regardless of what your OS setting is, as the components are meant to be placed on a white background.
|
Thanks! I think I'd prefer the canvas background to be set to white, and still allow storybook to be dark theme, but this is definitely an improvement as-is so will merge it in. |
|
@penx possible to have this deployed to GitHub Pages before the next version release? |
|
@davidwinter that should be done, are you able to test and let me know? |
|
Sorry for delay @penx - just to confirm this is now working as expected 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your OS (such as macOS) is set to use the dark theme, some browsers (like Firefox) pass this through to Storybook which will then use the dark theme as default. This means components will then not have a white background when viewing them within Storybook.
This PR sets the base theme to be the
lightStorybook theme, regardless of what your OS setting is, as the components are meant to be placed on a white background.Changed from:
To:
Checklist: