Add withWhiteSpace to spacing lib
#523
Conversation
* adds new `withWhiteSpace` function to spacing lib - generates spacing styles, accepting `margin`, `padding` and `mb` props - intended for use within styled component definitions `withWhiteSpace` HOC refactored to use function, but is now deprecated
|
Deploy preview for govuk-react processing. Building with commit c006739 https://app.netlify.com/sites/govuk-react/deploys/5c54211e568bc200086b81ff |
Codecov Report
@@ Coverage Diff @@
## master #523 +/- ##
==========================================
+ Coverage 99.77% 99.78% +0.01%
==========================================
Files 83 84 +1
Lines 440 467 +27
Branches 29 30 +1
==========================================
+ Hits 439 466 +27
Misses 1 1
Continue to review full report at Codecov.
|
|
I am guessing this is a breaking change so needs a point release? |
|
The CONTRIBUTING.md doc will need updating |
|
ah ok maybe not breaking... but breaking when we move to styled-components? |
|
Yeah - this won't be breaking by itself. When we actually remove the |
We are moving to styled-components (see #520). v0.5.x will remain as emotion releases as long as there are upstream users that don't want to switch to styled-components, but the point release will no longer indicate breaking vs. non breaking. Changes in this release: ## Util Add new spacing lib (#514) Enhanced withWhiteSpace HOC (#515) Add `withWhiteSpace` to spacing lib (#523) ## Breaking style changes Fix/Improve component typography (#519) Button shadow colour tweak (#513) Update Button styling (#512) Typography updates (#508) ## Documentation/dev tooling Minor readme updates (#510)
withWhiteSpacefunction to spacing libmargin,paddingandmbpropswithWhiteSpaceHOC refactored to use function, but is now deprecatedAims to provide a solution to #522
Checklist: