Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to TypeScript #875

Merged
merged 12 commits into from May 31, 2021
Merged

Convert to TypeScript #875

merged 12 commits into from May 31, 2021

Conversation

penx
Copy link
Member

@penx penx commented May 31, 2021

Closes #858

@codecov-commenter
Copy link

Codecov Report

Merging #875 (69082d3) into main (d585f09) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #875   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         114      114           
  Lines         821      825    +4     
  Branches      230      234    +4     
=======================================
+ Hits          816      820    +4     
  Misses          5        5           
Impacted Files Coverage Δ
components/back-link/src/index.tsx 100.00% <ø> (ø)
components/breadcrumbs/src/atoms/link/index.tsx 100.00% <ø> (ø)
components/breadcrumbs/src/index.tsx 100.00% <ø> (ø)
components/button/src/index.tsx 100.00% <ø> (ø)
components/caption/src/index.tsx 100.00% <ø> (ø)
components/checkbox/src/index.tsx 100.00% <ø> (ø)
components/date-field/src/index.tsx 100.00% <ø> (ø)
components/date-field/src/input.tsx 100.00% <ø> (ø)
components/details/src/index.tsx 100.00% <ø> (ø)
components/document-footer-metadata/src/index.tsx 100.00% <ø> (ø)
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d585f09...69082d3. Read the comment docs.

@penx penx merged commit c99940e into main May 31, 2021
@penx penx deleted the typescript branch May 31, 2021 13:09
@penx penx mentioned this pull request Sep 6, 2021
penx added a commit that referenced this pull request Sep 6, 2021
## Significant changes

The main thing to note is that the code is now in TypeScript. Though this compiles, some validation issues remain that intend to be addressed in 0.9.2. We hope to also publish types in 0.9.2 once the validation issues have been resolved.

Some changes have also been made to form components, particularly FileUpload, though we don't expect these to be breaking changes.

- Convert to TypeScript (#875)
- Add React.forwardRef to some form components (#923, #938)
- Improvements to FileUpload (#924)

## Enhancements

- Fix typings on backLink (#920)
- Migrate more tests to @testing-library/react (#909)

## Bug fixes

- LabelText should not be bold on error (#939)

## Documentation

- Add all form components to example application (#880)
- Add Final Form example and Cypress tests (#887)
- Add Formik to example application (#893)
- Add react-hook-form to example application (#916)
- react-jsonschema-form example (#935)
- Make example forms only validate on submit (#928)
- Why is this a monorepo in readme (#937)
- Misc improvements to forms examples and fixes to forward refs (#923)
- Fix docs (#878)
- Add file uploads to example application and Cypress tests (#924)

## Testing/CI/Misc

- Add jetbrains config to gitignore (#904)
- Reenable Chromatic (#903)
- Merge unit and regression coverage (#906)
- Add storyshots config (#902)

## Dependencies

- Bump react-transition-group from 4.4.1 to 4.4.2 (#934)
- Bump cross-env from 5.2.1 to 7.0.3 (#932)
- Bump @babel/plugin-proposal-export-default-from from 7.12.13 to 7.14.5 (#933)
- Bump actions/setup-node from 2.3.0 to 2.4.0 (#930)
- Bump JamesIves/github-pages-deploy-action from 4.1.4 to 4.1.5 (#929)
- Bump fastify/github-action-merge-dependabot from 2.2.0 to 2.4.0 (#931)
- Bump @storybook/addons from 6.3.5 to 6.3.7 (#919)
- Bump @storybook/react from 6.3.5 to 6.3.6 (#914)
- Bump @testing-library/jest-dom from 5.12.0 to 5.14.1 (#913)
- Bump fastify/github-action-merge-dependabot from 2.1.1 to 2.2.0 (#911)
- Bump actions/setup-node from 2.2.0 to 2.3.0 (#912)
- Bump @storybook/react from 6.2.9 to 6.3.5 (#905)
- Bump @storybook/addon-links from 6.2.9 to 6.3.2 (#898)
- Bump @typescript-eslint/parser from 4.25.0 to 4.28.1 (#897)
- Bump actions/setup-node from 2.1.5 to 2.2.0 (#895)
- Bump JamesIves/github-pages-deploy-action from 4.1.3 to 4.1.4 (#896)
- Bump eslint-plugin-import from 2.23.2 to 2.23.4 (#883)
- Bump react-final-form from 4.1.0 to 6.5.3 (#884)
- Bump glob-promise from 4.1.0 to 4.2.0 (#882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to TypeScript
2 participants