Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

姓氏.json may not have region-specific translations #3

Closed
BSBMteam opened this issue May 29, 2022 · 2 comments
Closed

姓氏.json may not have region-specific translations #3

BSBMteam opened this issue May 29, 2022 · 2 comments

Comments

@BSBMteam
Copy link
Contributor

BSBMteam commented May 29, 2022

This file has no region-specific translations. For example, some entries are perfect! Other entries just have one unspecified translation

Is this on purpose since 「于震」 can't be translated to 「於震」?

 {
      "original": null,
      "conv": "于娜"
    },
    {
      "original": null,
      "conv": "zh-hans:于荣光;zh-hant:于榮光"
    },
    {
      "original": null,
      "conv": "于震"
    },
    {
      "original": null,
      "conv": "zh-hans:于朦胧;zh-hant:于朦朧"
    },
@BSBMteam BSBMteam changed the title 姓氏.json 姓氏.json may not have region-specific translations May 29, 2022
@Gowee
Copy link
Owner

Gowee commented May 30, 2022

Yes. That is intended, I suppose.

@Gowee
Copy link
Owner

Gowee commented May 30, 2022

It turns out that I looked past such a kind of rule. The converter implementation doesn't process them properly. Fixing...

Thanks for reporting.

@Gowee Gowee closed this as completed in f678a6f Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants