Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle #27

Merged
merged 10 commits into from
Mar 26, 2019
Merged

Circle #27

merged 10 commits into from
Mar 26, 2019

Conversation

gowerc
Copy link
Owner

@gowerc gowerc commented Mar 23, 2019

Hey some meta changes

First off it looks like travis is being ripped apart :( (link) so decided to move us over to circleci instead (first commit)

Then decided to add in a load of meta files that I had forgotten to add after the last build (second commit)

Then updated the pkgdown site which we had neglected for a while (third commit)

4th Commit is a pointless commit to trigger the CI

5th Commit is updating the code coverage. Its now setup to expect each new pull request to have a minimium of 65% code tested and the overall repository to not decrease in coverage by more than 4%

Copy link
Collaborator

@kieranjmartin kieranjmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to update pkgdown. Can we automate that build, or is this done in circle already?

CRAN-RELEASE Outdated
@@ -0,0 +1,2 @@
This package was submitted to CRAN on 2019-03-12.
Once it is accepted, delete this file and tag the release (commit 7a03a6791b).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should this be here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this file in latest commit

@gowerc gowerc changed the base branch from master to devel March 25, 2019 14:45
@gowerc gowerc merged commit e066a83 into devel Mar 26, 2019
@gowerc gowerc deleted the circle branch July 21, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants