Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CardView radius style is not applied #8

Closed
ticofab opened this issue Sep 20, 2015 · 9 comments
Closed

CardView radius style is not applied #8

ticofab opened this issue Sep 20, 2015 · 9 comments
Assignees
Labels

Comments

@ticofab
Copy link

ticofab commented Sep 20, 2015

Hi, and thanks for this library. Unfortunately I am not able to style the cardview in the material sheet. For instance, attributes such as cardCornerRadius or cardBackgroundColor don't have any effect, nor in my app nor trying to modify the sample app. Trying to achieve this via code doesn't work either. Have you noticed the same behaviour?

@gowong
Copy link
Owner

gowong commented Sep 20, 2015

Hi, are you able to style a cardview that isn't being used by the library? The fab doesn't override any of the sheet's existing styles except for the background colors, which you pass in the fab's constructor.

@gowong
Copy link
Owner

gowong commented Sep 24, 2015

No response. Feel free to reopen.

@gowong gowong closed this as completed Sep 24, 2015
@gowong gowong added the invalid label Sep 24, 2015
@ticofab
Copy link
Author

ticofab commented Sep 24, 2015

Hey @gowong , sorry I have had little time in the past few days. I can actually style other cardviews, Are you able to get rounded corners on the material sheet? Thanks again for this wonderful library.

@gowong
Copy link
Owner

gowong commented Sep 24, 2015

I think I had issues setting the radius on the cardviews in the past, but I can try again later today. Is it only the radius style that isn't working for you?

@ticofab
Copy link
Author

ticofab commented Sep 25, 2015

No - other attributes such as card_view:contentPadding are also not working.

@gowong
Copy link
Owner

gowong commented Sep 26, 2015

Okay, I found the issue that's preventing the cardCornerRadius from being applied on Android 5.0+, but it should already be working on older version of Android. Can you confirm that's the case?
I should be able to push a fix tomorrow.

@gowong gowong reopened this Sep 26, 2015
@gowong gowong added bug and removed invalid labels Sep 26, 2015
@gowong gowong changed the title can't style the cardview CardView radius style is not applied Sep 26, 2015
@ticofab
Copy link
Author

ticofab commented Sep 26, 2015

You are right -- attributes such as cardCornerRadius work fine on older version. Specifically, I tried it on 4.4.4 (KitKat).

@gowong gowong self-assigned this Sep 26, 2015
gowong added a commit that referenced this issue Sep 26, 2015
@gowong
Copy link
Owner

gowong commented Sep 26, 2015

Fixed in v1.0.5

@gowong gowong closed this as completed Sep 26, 2015
@ticofab
Copy link
Author

ticofab commented Sep 27, 2015

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants