Merge pull request #93 from IVOES/fix-badly-bounded-write

Fix badly bounded write
gozfree · May 27, 2023 · 05364f3 · 05364f3
2 parents 93d04a5 + 576c269
commit 05364f3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/gear-lib/librtsp/request_handle.c b/gear-lib/librtsp/request_handle.c
@@ -33,7 +33,7 @@
 #include <string.h>
 #include <time.h>
 
-#define RTSP_RESPONSE_LEN_MAX   (8192)
+#define RTSP_RESPONSE_LEN_MAX   (16384)
 
 #define ALLOWED_COMMAND                         \
         "OPTIONS,"                              \
@@ -144,7 +144,7 @@ static int on_describe(struct rtsp_request *req, char *url)
         return handle_rtsp_response(req, 404, NULL);
     }
     ms->sdp_generate(ms);
-    snprintf(buf, sizeof(buf)+sizeof(ms->sdp), RESP_DESCRIBE_FMT,
+    snprintf(buf, sizeof(buf), RESP_DESCRIBE_FMT,
                  req->url_origin,
                  (uint32_t)strlen(ms->sdp),
                  ms->sdp);//XXX: sdp line can't using "\r\n" as ending!!!