-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting of some arguments' help #2771
Comments
No, enums are uint however they are expressed as strings in the command line (just like every other type number/fraction/etc) . On the other hand, the
Yes, because most of them are not strict enums, they allow any names + some reserved names (cf logs) The pixel format, audio format and audio layout could be converted to enum, but currently their type is not an Could you detail more how this is problematic for your use case(s) ? |
It's not really a deal breaker, I just thought there might be some oversight but apperantly everything was well thought. For non-strict sums, are they signalled with a flag? |
What example do you have in mind ? |
For example, probe's log argument. It's an enum but it's not bound to enum values. Should I just use enum values as suggestions for
|
I did a cleanup pass, now all options using enum-like types (including pix fmts & co) will use For mixed values like inspect.log, the convention is that "_any" should be used to indicate free string. |
,
) instead of bar (|
). This comes fromconstants.h
. I've tried to change it but it broke something else and I cannot find what is affected by this.uint
but actually they are string. In the code thisuint
is used as index to get the proper value. Wouldn't make more sense to convert these tostr
type?I've listed the affected filters in the attached JSONs.
uints.json
comma.json
The text was updated successfully, but these errors were encountered: