Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wasm build, usage of
gettimeofday()
is painfully slow when gpac runs on a worker. Emscripten offers a substitute for it. I had to make this change because when I profiled my application, almost all of the time wasm made a call to javascript to get the time and it stalled the entire stack because of it.I haven't fully tested it but as emscripten documentation pointed out, this might use
performance.now()
. Which means between different workers (threads) this value will have a different origin (mdn reference). Depending on how these clocks are used internally the implementation might need to change. For reference, here is how this function is defined in emscripten:https://github.com/emscripten-core/emscripten/blob/main/system/lib/standalone/standalone.c#L179-L185
fixes #2775
related urho3d/urho3d#916