Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Fix finding xvid by including stddef.h for definition of NULL #2822

Merged
merged 1 commit into from
May 1, 2024

Conversation

ryandesign
Copy link
Contributor

The configure test for xvid was failing to find it due to

*** CC/CXX Test Failed (res 1 args -L/opt/local/lib -Wl,-headerpad_max_install_names -Wl,-syslibroot,/Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk -arch x86_64 -arch x86_64 -L/opt/local/lib -lxvidcore -lpthread) : 

/opt/local/var/macports/build/_Volumes_Shared_macports-ports_multimedia_gpac/gpac/work/.tmp/gpac-conf-30001-60580-19987.c:2:70: error: use of undeclared identifier 'NULL'
int main( void ) { void *codec; xvid_decore(codec, XVID_DEC_DESTROY, NULL, NULL); return 0; }
                                                                     ^
/opt/local/var/macports/build/_Volumes_Shared_macports-ports_multimedia_gpac/gpac/work/.tmp/gpac-conf-30001-60580-19987.c:2:76: error: use of undeclared identifier 'NULL'
int main( void ) { void *codec; xvid_decore(codec, XVID_DEC_DESTROY, NULL, NULL); return 0; }
                                                                           ^
2 errors generated.

Source was: 
#include <xvid.h>
int main( void ) { void *codec; xvid_decore(codec, XVID_DEC_DESTROY, NULL, NULL); return 0; }

Fix by including <stddef.h> anytime NULL is referenced.

The configure test for xvid was failing to find it due to "error: use of
undeclared identifier 'NULL'". Fix by including <stddef.h> anytime NULL
is referenced.
@rbouqueau
Copy link
Member

Thank you! LGTM, merging.

@rbouqueau rbouqueau merged commit 434c3df into gpac:master May 1, 2024
@ryandesign ryandesign deleted the patch-1 branch May 1, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants