Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for kFreeBSD and GNU Hurd #20

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yangfl
Copy link

@yangfl yangfl commented Apr 11, 2020

@darealshinji
Copy link

I would add the _GNU_SOURCE like this:

#ifndef _GNU_SOURCE
#define _GNU_SOURCE
#endif

@darealshinji
Copy link

I think a correct check for kFreeBSD would be #if defined(__linux__) || ... || (defined(__FreeBSD_kernel__) && defined(__GLIBC__))

You need to check for __GLIBC__ to as FreeBSD also defines __FreeBSD_kernel__

@yangfl
Copy link
Author

yangfl commented Oct 16, 2023

I think it's enough to check __GNU__ only since we do not really care whether it is __FreeBSD_kernel__ or something else, just GNU-like environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants