Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 8 orientation issue #77

Closed
taymer opened this issue May 6, 2015 · 8 comments
Closed

iOS 8 orientation issue #77

taymer opened this issue May 6, 2015 · 8 comments

Comments

@taymer
Copy link

taymer commented May 6, 2015

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.

@barrettj
Copy link
Collaborator

barrettj commented May 6, 2015

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a rotation issue: the background and the alertView are no more centered.


Reply to this email directly or view it on GitHub.

@taymer
Copy link
Author

taymer commented May 6, 2015

Yes, but i updated manually.
Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha
scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a
rotation issue: the background and the alertView are no more centered.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#77 (comment)
.

@barrettj
Copy link
Collaborator

barrettj commented May 6, 2015

In your history do you see the following commit:

1f98983 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually.
Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha
scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com wrote:

Opening a BlockAlertView and changing device orientation causes a
rotation issue: the background and the alertView are no more centered.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#77 (comment)
.


Reply to this email directly or view it on GitHub #77 (comment).

@taymer
Copy link
Author

taymer commented May 6, 2015

Yes on blockbackround.m (if i remember correctly) I wonder you can' t
reproduce the issue.
I've just tested the demo app. Running on iOs 8.3 both on iPhone 6 and ipad
3. Open the alert and rotate the device.

Thanks.
Il 06/mag/2015 19:38, "Barrett Jacobsen" notifications@github.com ha
scritto:

In your history do you see the following commit:

1f98983 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually.
Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha
scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com
wrote:

Opening a BlockAlertView and changing device orientation causes a
rotation issue: the background and the alertView are no more centered.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
<
#77 (comment)

.


Reply to this email directly or view it on GitHub <
#77 (comment)
.


Reply to this email directly or view it on GitHub
#77 (comment)
.

@barrettj
Copy link
Collaborator

barrettj commented May 6, 2015

Interesting. I definitely see this in the demo project, but not in my actual app that I use the alert in.

On May 6, 2015, at 12:54 PM, taymer notifications@github.com wrote:

Yes on blockbackround.m (if i remember correctly) I wonder you can' t
reproduce the issue.
I've just tested the demo app. Running on iOs 8.3 both on iPhone 6 and ipad
3. Open the alert and rotate the device.

Thanks.
Il 06/mag/2015 19:38, "Barrett Jacobsen" notifications@github.com ha
scritto:

In your history do you see the following commit:

1f98983 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually.
Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha
scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com
wrote:

Opening a BlockAlertView and changing device orientation causes a
rotation issue: the background and the alertView are no more centered.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
<
#77 (comment)

.


Reply to this email directly or view it on GitHub <
#77 (comment)
.


Reply to this email directly or view it on GitHub
#77 (comment)
.


Reply to this email directly or view it on GitHub #77 (comment).

@barrettj
Copy link
Collaborator

barrettj commented May 6, 2015

Try the commit I just pushed, it disables all custom rotation stuff on iOS 8 which should hopefully fix things.

On May 6, 2015, at 12:54 PM, taymer notifications@github.com wrote:

Yes on blockbackround.m (if i remember correctly) I wonder you can' t
reproduce the issue.
I've just tested the demo app. Running on iOs 8.3 both on iPhone 6 and ipad
3. Open the alert and rotate the device.

Thanks.
Il 06/mag/2015 19:38, "Barrett Jacobsen" notifications@github.com ha
scritto:

In your history do you see the following commit:

1f98983 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com wrote:

Yes, but i updated manually.
Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com ha
scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com
wrote:

Opening a BlockAlertView and changing device orientation causes a
rotation issue: the background and the alertView are no more centered.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
<
#77 (comment)

.


Reply to this email directly or view it on GitHub <
#77 (comment)
.


Reply to this email directly or view it on GitHub
#77 (comment)
.


Reply to this email directly or view it on GitHub #77 (comment).

@taymer
Copy link
Author

taymer commented May 6, 2015

I' ll try tomorrow. I've no mac with me now (it' s evening in Italy ;-] )
Il 06/mag/2015 21:19, "Barrett Jacobsen" notifications@github.com ha
scritto:

Try the commit I just pushed, it disables all custom rotation stuff on iOS
8 which should hopefully fix things.

On May 6, 2015, at 12:54 PM, taymer notifications@github.com wrote:

Yes on blockbackround.m (if i remember correctly) I wonder you can' t
reproduce the issue.
I've just tested the demo app. Running on iOs 8.3 both on iPhone 6 and
ipad
3. Open the alert and rotate the device.

Thanks.
Il 06/mag/2015 19:38, "Barrett Jacobsen" notifications@github.com ha
scritto:

In your history do you see the following commit:

1f98983 fix for ios 8 rotation

It should be from 4/17/15

On May 6, 2015, at 12:33 PM, taymer notifications@github.com
wrote:

Yes, but i updated manually.
Il 06/mag/2015 18:42, "Barrett Jacobsen" notifications@github.com
ha
scritto:

Are you using cocoa pods?

Sent from my iPhone

On May 6, 2015, at 11:22 AM, taymer notifications@github.com
wrote:

Opening a BlockAlertView and changing device orientation causes a
rotation issue: the background and the alertView are no more
centered.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
<

#77 (comment)

.


Reply to this email directly or view it on GitHub <

#77 (comment)

.


Reply to this email directly or view it on GitHub
<
#77 (comment)

.


Reply to this email directly or view it on GitHub <
#77 (comment)
.


Reply to this email directly or view it on GitHub
#77 (comment)
.

@taymer
Copy link
Author

taymer commented May 7, 2015

It's OK.
Thanks a lot.

@taymer taymer closed this as completed May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants