Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overflow of budgets #205

Closed
phanikishoreg opened this issue Oct 7, 2016 · 2 comments
Closed

overflow of budgets #205

phanikishoreg opened this issue Oct 7, 2016 · 2 comments

Comments

@phanikishoreg
Copy link
Member

Transferring budgets to a tcap, could cause the tcap_res_t to overflow or even promote it to a INF budget tcap.

Need to handle by having a maximum possible budget, like MAX=INF - 1.
Only transfer up to the MAX amount and return, but this may not be consistent with the current implementation which doesn't allow transferring budgets less than expected cycles (ex: if a tcap has 100 cycles and the transfer request was for 150 cycles, it returns error currently).

For consistency, either error out in both cases or transfer as much as possible/available.

@phanikishoreg
Copy link
Member Author

PR #209 Commit: 39e9c96 fixes this issue.

@Others
Copy link
Contributor

Others commented Oct 17, 2017

Fixed by #209

@Others Others closed this as completed Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants