Skip to content
This repository has been archived by the owner on Nov 17, 2017. It is now read-only.

Use ES6 in webpack prod config #49

Closed
rafayepes opened this issue May 26, 2015 · 4 comments
Closed

Use ES6 in webpack prod config #49

rafayepes opened this issue May 26, 2015 · 4 comments

Comments

@rafayepes
Copy link

It is confusing to see the dev config in ES6, like all the code and then the prod config in ES5.

Any particular reason for that?

@gpbl
Copy link
Owner

gpbl commented May 26, 2015

Yes: I couldn't find a way to pass to the webpack bin (used by the npm run build script) a config written in ES6. On dev we don't use the bin so we require the config in a node.js script, after babel/register hook has been installed. Anyway it's a good point, going to ask on the webpack's gitter chat...

@rafayepes
Copy link
Author

What about doing something similar to that?

https://github.com/gpbl/isomorphic500/blob/31e91c650c4b99d91424ecbef6e13531ab50e9a1/src/config.js

and load babel/register in this config?

@gpbl
Copy link
Owner

gpbl commented May 26, 2015

Yes I was thinking to that option, but perhaps keeping the config (and /webpack/utils) in ES5 would be a better compromise.

@rafayepes
Copy link
Author

Yeah. Maybe just less tricky and it will be more consistent that having one
config in ES6 and another in ES5.

On 26 May 2015 at 21:33, Giampaolo Bellavite notifications@github.com
wrote:

Yes I was thinking to that option, but perhaps keeping the config (and
/webpack/utils) in ES5 would be a better compromise.


Reply to this email directly or view it on GitHub
#49 (comment).

@gpbl gpbl closed this as completed in e401df1 May 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants