fix: matcherToArray should return a copy of the array (#1609)

gpbl · Nov 20, 2022 · baf9f34 · baf9f34
1 parent 120fb1d
commit baf9f34
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/react-day-picker/src/contexts/Modifiers/utils/matcherToArray.test.ts b/packages/react-day-picker/src/contexts/Modifiers/utils/matcherToArray.test.ts
@@ -10,8 +10,11 @@ describe('when a Matcher is passed in', () => {
 });
 
 describe('when an array of Matchers is passed in', () => {
-  test('should return the array', () => {
-    expect(matcherToArray([matcher])).toStrictEqual([matcher]);
+  test('should return a copy of the array', () => {
+    const value = [matcher, matcher];
+    const result = matcherToArray(value);
+    expect(result).toStrictEqual(value);
+    expect(result).not.toBe(value);
   });
 });
 

diff --git a/packages/react-day-picker/src/contexts/Modifiers/utils/matcherToArray.ts b/packages/react-day-picker/src/contexts/Modifiers/utils/matcherToArray.ts
@@ -5,7 +5,7 @@ export function matcherToArray(
   matcher: Matcher | Matcher[] | undefined
 ): Matcher[] {
   if (Array.isArray(matcher)) {
-    return matcher;
+    return [...matcher];
   } else if (matcher !== undefined) {
     return [matcher];
   } else {