Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyboard navigation bug when using custom classNames #268

Closed
oigewan opened this issue Mar 5, 2017 · 2 comments
Closed

Fix keyboard navigation bug when using custom classNames #268

oigewan opened this issue Mar 5, 2017 · 2 comments

Comments

@oigewan
Copy link

oigewan commented Mar 5, 2017

The DayPicker.getDayNodes method is essential to the keyboard navigation functionality working correctly. However, it has hardcoded assumptions about what the classes for a day and an "outside" day are. This means that attempting to use the keyboard to select a day becomes impossible if the user passes in something on the classNames prop.
@oigewan oigewan mentioned this issue Mar 5, 2017
Merged
@gpbl gpbl added the bug label Mar 6, 2017
@gpbl
Copy link
Owner

gpbl commented Mar 6, 2017

Woah thanks for reporting this and for the PR 👍 going to release an update.

@gpbl gpbl closed this as completed in #269 Mar 6, 2017
@gpbl
Copy link
Owner

gpbl commented Mar 6, 2017

Fixed in v5.1.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpbl @oigewan